[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01#8458
Merged
erich-wang merged 3 commits intomasterfrom Feb 22, 2020
Merged
Conversation
…eDays (#8457) Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com>
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
This was referenced Feb 21, 2020
majastrz
reviewed
Feb 21, 2020
specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Add default=90 to softDeleteRetentionInDays Add default=90 to softDeleteRetentionInDays * Remove default softDeleteRetentionInDays when patching Remove default softDeleteRetentionInDays when patching.
|
Azure Pipelines successfully started running 1 pipeline(s). |
schaabs
approved these changes
Feb 21, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
The validation passed, I checked the two checkboxes in the issue description which retriggered the pipelines, then they failed (i.e. no code changes). @akning-ms can your team look into this? |
Member
Author
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run automation - sdk Timeout in JavaScript SDK generation - the other ones that previous failed without code change passed. |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…stable/2019-09-01 (Azure#8458) * Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays (Azure#8457) Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> * Added `enableRbacAuthorization` property to Key Vault management plane (Azure#8468) * Add default=90 to softDeleteRetentionInDays (Azure#8476) * Add default=90 to softDeleteRetentionInDays Add default=90 to softDeleteRetentionInDays * Remove default softDeleteRetentionInDays when patching Remove default softDeleteRetentionInDays when patching. Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: